Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement multiple Rooms support (#27) #147

Merged
merged 59 commits into from
Nov 6, 2020
Merged

Implement multiple Rooms support (#27) #147

merged 59 commits into from
Nov 6, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 8, 2020 •
edited
Loading

Part of #27

Synopsis

Jason should be able to serve multiple Rooms with one Jason object. If Jason client joins to the many Rooms from the one Media Server, then only one WebSocket connection should serve all this Rooms.

Solution

Add authorization messages to the medea-client-api-proto. Authorize Members with this messages instead of doing it by URL with which Member connects to the Media Server.

Create wrapper around Jason's WebSocketRpcClient which will be responsible for routing and sessions management.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed
    • e2e-demo changes are rollbacked

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture labels Oct 8, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Oct 8, 2020
@evdokimovs evdokimovs self-assigned this Oct 8, 2020
This was referenced Oct 8, 2020
Merged
Merged
@alexlapa alexlapa requested a review from tyranron November 2, 2020 12:32
tyranron
tyranron suggested changes Nov 5, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to redesign that protocol thing.

@evdokimovs evdokimovs requested a review from tyranron November 5, 2020 14:35
@tyranron tyranron changed the title Draft: Implement multiple Rooms support (#27) Implement multiple Rooms support (#27) Nov 6, 2020
@evdokimovs evdokimovs merged commit 745a56e into master Nov 6, 2020
@evdokimovs evdokimovs deleted the multiple-rooms branch November 6, 2020 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa